CG -4453 should keep search by value as selected when searching #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doanthanhnguyen95
commented
Jun 28, 2023
doanthanhnguyen95
commented
- Add new query string in order to keep the search by value as selected whenever user do a new search
- Make the param displayed as an empty string instead of undefined - This bugfix also include CG-4434 Wrong search value when user click on the number of an item in facets
- Add filter query string
doanthanhnguyen95
requested review from
ThanhCN85,
cimdalli,
jamestran1,
juntezhang and
ngoctuyennguyen-opti
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jamestran1
approved these changes
Jun 28, 2023
ngoctuyennguyen-opti
approved these changes
Jun 30, 2023
doanthanhnguyen95
deleted the
bugfix/CG-4453-Should-keep-SearchBy-value-as-selected-when-searching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.